Page MenuHomePhabricator
Differential D21539

Detect and correct "final private" methods in lint
ClosedPublic
Actions

Authored by epriestley on Feb 3 2021, 9:53 PM.
Tags
None
Referenced Files
F22662796: D21539.id51274.diff
Thu, Oct 1, 10:32 AM
F22627416: D21539.id51274.diff
Tue, Sep 29, 10:08 PM
Unknown Object (File)
Aug 30 2026, 10:21 PM
Unknown Object (File)
Aug 21 2026, 5:10 AM
Unknown Object (File)
Jul 30 2026, 2:29 AM
Unknown Object (File)
Jul 2 2026, 7:04 PM
Unknown Object (File)
Jun 18 2026, 12:20 AM
Unknown Object (File)
Jun 12 2026, 1:58 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13588: PHP 8 Compatibility
Commits
rARCc51a996fb0bb: Detect and correct "final private" methods in lint
Summary

Ref T13588. Marking a method "final private" has never been meaningful, and is an error in PHP8.

Add static analysis to detect (and correct) this issue.

Test Plan

Added unit tests, will lint "phabricator/".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 3 2021, 9:53 PM
Harbormaster completed remote builds in B25085: Diff 51271.Feb 3 2021, 9:53 PM
epriestley requested review of this revision.Feb 3 2021, 9:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 10:14 PM
Closed by commit rARCc51a996fb0bb: Detect and correct "final private" methods in lint (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCc51a996fb0bb: Detect and correct "final private" methods in lint.
epriestley mentioned this in T13588: PHP 8 Compatibility.Feb 3 2021, 10:52 PM

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
xhpast/
rules/
78 lines
__tests__/
invalid-modifiers/
26 lines
parser/
aast/
api/
11 lines

Diff 51274

View Options

src/lint/linter/xhpast/rules/ArcanistInvalidModifiersXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/invalid-modifiers/invalid-modifiers.lint-test

Loading...
View Options

src/parser/aast/api/AASTToken.php

Loading...
Phabricator · Built by Phacility