Page MenuHomePhabricator

Detect and correct "final private" methods in lint
ClosedPublic

Authored by epriestley on Feb 3 2021, 9:53 PM.

Details

Summary

Ref T13588. Marking a method "final private" has never been meaningful, and is an error in PHP8.

Add static analysis to detect (and correct) this issue.

Test Plan

Added unit tests, will lint "phabricator/".

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 10:14 PM
This revision was automatically updated to reflect the committed changes.