Page MenuHomePhabricator

Detect and correct "final private" methods in lint
ClosedPublic

Authored by epriestley on Feb 3 2021, 9:53 PM.
Tags
None
Referenced Files
F15584321: D21539.id51271.diff
Thu, May 8, 2:52 AM
F15539743: D21539.diff
Fri, Apr 25, 4:06 AM
F15525450: D21539.id51271.diff
Mon, Apr 21, 2:32 PM
F15524690: D21539.diff
Mon, Apr 21, 9:44 AM
F15504638: D21539.id51274.diff
Mon, Apr 14, 7:30 PM
F15497055: D21539.id51274.diff
Sun, Apr 13, 9:37 AM
F15496682: D21539.id51271.diff
Sun, Apr 13, 7:33 AM
F15491961: D21539.id.diff
Sat, Apr 12, 9:22 AM
Subscribers
None

Details

Summary

Ref T13588. Marking a method "final private" has never been meaningful, and is an error in PHP8.

Add static analysis to detect (and correct) this issue.

Test Plan

Added unit tests, will lint "phabricator/".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 10:14 PM
This revision was automatically updated to reflect the committed changes.