Although this provides less context in terms of the error message (for example, Parameter has invalid type. Expected type 'optional regex|list<regex>', got type 'list<string>'.), I think that it is the right approach. I think that PhutilTypeSpec::checkMap should be improved such that additional context is provided in the exception message.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARCb744ed9a19ce: Be more strict with the type of `.arclint` properties.
Ran arc lint. Modified .arclint to contain an invalid regex and ran arc lint again.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| src/lint/engine/ArcanistConfigurationDrivenLintEngine.php | ||
|---|---|---|
| 71–86 | Sure, but how can we know which key was invalid? | |
Comment Actions
Just raising the linter key would be helpful -- "There was an error in the configuration for linter "%s": ..." or similar
Comment Actions
Closed by commit rARCb744ed9a19ce (authored by @joshuaspence, committed by @epriestley).