Improve the "unexpected return value" linter rule
9e78d15fc0c7
Actions

Description

Improve the "unexpected return value" linter rule

Summary: Return values within constructors are acceptable if they are within a closure or anonymous function.

Test Plan: Added a test case.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14564

Details

Provenance

joshuaspence	Authored on
joshuaspence	Pushed on Nov 23 2015, 11:01 PM

Reviewer

Blessed Reviewers

Differential Revision

D14564: Improve the "unexpected return value" linter rule

Parents

rARC72d9013d29dc: Add a linter rule for `abstract` methods containing a body

Branches

Unknown

Tags

Unknown

Build Status

Buildable 9037
Build 10624: Run Core Tests

Event Timeline

joshuaspence committed rARC9e78d15fc0c7: Improve the "unexpected return value" linter rule (authored by joshuaspence).Nov 23 2015, 11:01 PM

Harbormaster completed building B9037: rARC9e78d15fc0c7: Improve the "unexpected return value" linter rule.Nov 23 2015, 11:01 PM

andl mentioned this in T8404: Running the cpplint linter through arcanist no longer works.Nov 25 2015, 3:10 PM

nickz mentioned this in T9904: The Paste app doesn't work.Dec 4 2015, 11:38 PM

nnnn20430 mentioned this in T9465: Construction of a DateTime() with epoch raised an exception.Dec 6 2015, 7:30 PM

Changes (2)

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistUnexpectedReturnValueXHPASTLinterRule.php

__tests__/

unexpected-return-value/

closure.lint-test

rARC9e78d15fc0c7

View Options

src/lint/linter/xhpast/rules/ArcanistUnexpectedReturnValueXHPASTLinterRule.php