Page MenuHomePhabricator

Improve the "unexpected return value" linter rule
ClosedPublic

Authored by joshuaspence on Nov 23 2015, 10:52 PM.
Tags
None
Referenced Files
F15540908: D14564.id35228.diff
Fri, Apr 25, 9:38 AM
F15539201: D14564.diff
Fri, Apr 25, 12:07 AM
F15520897: D14564.id35228.diff
Sun, Apr 20, 9:04 AM
F15514248: D14564.diff
Fri, Apr 18, 1:12 AM
F15507670: D14564.id35228.diff
Tue, Apr 15, 9:56 PM
F15497420: D14564.id35227.diff
Sun, Apr 13, 10:27 AM
F15486882: D14564.id35228.diff
Thu, Apr 10, 9:54 AM
F15467293: D14564.id35228.diff
Thu, Apr 3, 1:58 PM
Subscribers

Details

Summary

Return values within constructors are acceptable if they are within a closure or anonymous function.

Test Plan

Added a test case.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Improve the "unexpected return value" linter rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2015, 10:52 PM
This revision was automatically updated to reflect the committed changes.