Page MenuHomePhabricator

Improve the "unexpected return value" linter rule
ClosedPublic

Authored by joshuaspence on Nov 23 2015, 10:52 PM.
Tags
None
Referenced Files
F15467293: D14564.id35228.diff
Thu, Apr 3, 1:58 PM
F15453467: D14564.diff
Sat, Mar 29, 12:03 PM
F15429323: D14564.id35228.diff
Mon, Mar 24, 1:40 AM
F15409623: D14564.id35228.diff
Wed, Mar 19, 4:47 AM
F15405923: D14564.diff
Tue, Mar 18, 12:01 PM
F15377346: D14564.id35228.diff
Thu, Mar 13, 8:39 AM
F15311734: D14564.id35228.diff
Mar 6 2025, 10:33 AM
Unknown Object (File)
Feb 28 2025, 7:32 AM
Subscribers

Details

Summary

Return values within constructors are acceptable if they are within a closure or anonymous function.

Test Plan

Added a test case.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Improve the "unexpected return value" linter rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2015, 10:52 PM
This revision was automatically updated to reflect the committed changes.