HomePhabricator

Simplified the logic in various functions.

Description

Simplified the logic in various functions.

Summary:

  • Tidied up ArcanistCSSLintLinter::getDefaultBinary.
  • Tidied up CSSLintLinter::getDefaultFlags function.
  • Tidied up ArcanistPhpcsLinter::getDefaultBinary function.
  • Tidied up ArcanistPEP8Linter::getDefaultFlags function
  • Tidied up ArcanistFlake8Linter::getDefaultFlags.
  • Tidied up ArcanistCppcheckLinter::getLintOptions.
  • Tidied up ArcanistCppcheckLinter::getLintPath.
  • Tidied up ArcanistCpplintLinter::getLintOptions.
  • Tidied up ArcanistCpplintLinter::getLintPath.
  • Removed child functions which are identical to the corresponding parent functions.

Test Plan: arc lint and arc unit.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: epriestley

CC: chad, Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8385

Details

Provenance
joshuaspenceAuthored on
epriestleyCommitted on Mar 4 2014, 7:00 PM
epriestleyPushed on Mar 4 2014, 7:00 PM
Reviewer
epriestley
Differential Revision
D8385: Simplified the logic in various functions.
Parents
rARC9fb2a147f90b: Made `ArcanistNoLintTestCaseMisnamed` final.
Branches
Unknown
Tags
Unknown

Event Timeline