Page MenuHomePhabricator

Simplified the logic in various functions.
ClosedPublic

Authored by joshuaspence on Mar 3 2014, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 6:19 AM
Unknown Object (File)
Fri, Dec 13, 8:14 PM
Unknown Object (File)
Thu, Dec 12, 11:12 PM
Unknown Object (File)
Mon, Dec 9, 2:24 AM
Unknown Object (File)
Fri, Nov 29, 4:59 PM
Unknown Object (File)
Fri, Nov 29, 2:01 PM
Unknown Object (File)
Wed, Nov 27, 12:23 AM
Unknown Object (File)
Wed, Nov 27, 12:23 AM

Details

Summary
  • Tidied up ArcanistCSSLintLinter::getDefaultBinary.
  • Tidied up CSSLintLinter::getDefaultFlags function.
  • Tidied up ArcanistPhpcsLinter::getDefaultBinary function.
  • Tidied up ArcanistPEP8Linter::getDefaultFlags function
  • Tidied up ArcanistFlake8Linter::getDefaultFlags.
  • Tidied up ArcanistCppcheckLinter::getLintOptions.
  • Tidied up ArcanistCppcheckLinter::getLintPath.
  • Tidied up ArcanistCpplintLinter::getLintOptions.
  • Tidied up ArcanistCpplintLinter::getLintPath.
  • Removed child functions which are identical to the corresponding parent functions.
Test Plan

arc lint and arc unit.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Skipping php54.lint-test, all unit tests pass.

epriestley edited edge metadata.

Great, thanks!

This revision is now accepted and ready to land.Mar 4 2014, 6:59 PM