Page MenuHomePhabricator

Simplified the logic in various functions.
ClosedPublic

Authored by joshuaspence on Mar 3 2014, 12:02 AM.
Tags
None
Referenced Files
F15333988: D8385.id19934.diff
Sat, Mar 8, 6:06 AM
F15332667: D8385.diff
Fri, Mar 7, 7:00 PM
Unknown Object (File)
Sun, Feb 23, 10:19 PM
Unknown Object (File)
Feb 19 2025, 11:02 PM
Unknown Object (File)
Feb 15 2025, 9:41 AM
Unknown Object (File)
Feb 15 2025, 9:41 AM
Unknown Object (File)
Feb 15 2025, 9:41 AM
Unknown Object (File)
Feb 10 2025, 12:28 AM

Details

Summary
  • Tidied up ArcanistCSSLintLinter::getDefaultBinary.
  • Tidied up CSSLintLinter::getDefaultFlags function.
  • Tidied up ArcanistPhpcsLinter::getDefaultBinary function.
  • Tidied up ArcanistPEP8Linter::getDefaultFlags function
  • Tidied up ArcanistFlake8Linter::getDefaultFlags.
  • Tidied up ArcanistCppcheckLinter::getLintOptions.
  • Tidied up ArcanistCppcheckLinter::getLintPath.
  • Tidied up ArcanistCpplintLinter::getLintOptions.
  • Tidied up ArcanistCpplintLinter::getLintPath.
  • Removed child functions which are identical to the corresponding parent functions.
Test Plan

arc lint and arc unit.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Skipping php54.lint-test, all unit tests pass.

epriestley edited edge metadata.

Great, thanks!

This revision is now accepted and ready to land.Mar 4 2014, 6:59 PM