Fix an DOMDocument error with NoseTestEngine running on PHP 7
Audit Required296250485541

Authored by 20after4 on Oct 5 2016, 8:19 PM.

Description

Fix an DOMDocument error with NoseTestEngine running on PHP 7

Summary:
In php 7, DOMDocument::loadXML emits an error when supplied with
an empty string as input. For example, I got this error:

ERROR 2: DOMDocument::loadXML(): Empty string supplied as input

This change simply checks for empty and returns an empty array
rather than attempting to parse an empty xml document.

Test Plan: ran arc diff on a repo that uses nosetestengine

Reviewers: Blessed Reviewers!

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D16672

Details

Auditors
adampetrovic
H140 Triggered Audit
Committed
20after4Oct 9 2016, 9:28 PM
Pushed
20after4Oct 9 2016, 9:29 PM
Differential Revision
D16672: Fix an DOMDocument error with NoseTestEngine running on PHP 7
Parents
rARC2ad15c499a00: Don't compute intraline diffs if the input fails a coarse check for being huge
Branches
Unknown
Tags
Unknown