Page MenuHomePhabricator

Diffusion "land revision" browser command runs from diff author instead click author
Closed, InvalidPublic

Description

Steps to reproduction:

  1. Create or select any repo
  2. Set to pushable users in this repo only yourself
  3. Create new diff from different user to this repo
  4. Try to "land" this diff in browser from youself.

Versions:

  • phabricator ea6db2ae9bf25a93ff6696d1bff2c99054f9ddd3 (Wed, Oct 12)
  • arcanist 2962504855413be1dce6f4bcffd6283bc657fb6f (Mon, Oct 10)
  • phutil 50cd143e07ca3802e761e810edeb31f756e33082 (Fri, Oct 7)

Screencast:

Related Objects

Event Timeline

saggid updated the task description. (Show Details)
saggid added a project: Differential.
saggid renamed this task from Diffusion "land revision" browser command makes from diff author instead click author to Diffusion "land revision" browser command runs from diff author instead click author.Oct 12 2016, 5:24 PM
saggid mentioned this in Z1336: General Chat.
epriestley added a subscriber: epriestley.
  • To click the "Land Revision" link, you must be able to push to the repository.
  • The push is performed by the user that Drydock is operating as on the automation host.
  • The reproduction steps and video above are consistent with this.

Yes, this is my mistake, sorryyy