Page MenuHomePhabricator

Fix an DOMDocument error with NoseTestEngine running on PHP 7
ClosedPublic

Authored by 20after4 on Oct 5 2016, 8:23 PM.

Details

Summary

In php 7, DOMDocument::loadXML emits an error when supplied with
an empty string as input. For example, I got this error:

ERROR 2: DOMDocument::loadXML(): Empty string supplied as input

This change simply checks for empty and returns an empty array
rather than attempting to parse an empty xml document.

Test Plan

ran arc diff on a repo that uses nosetestengine

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

20after4 updated this revision to Diff 40133.Oct 5 2016, 8:23 PM
20after4 retitled this revision from to Fix an DOMDocument error with NoseTestEngine running on PHP 7.
20after4 updated this object.
20after4 edited the test plan for this revision. (Show Details)
epriestley accepted this revision.Oct 5 2016, 8:23 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Oct 5 2016, 8:23 PM
wizsrk added a subscriber: wizsrk.

Please review this

src/unit/engine/NoseTestEngine.php
129–132

Nice work here

wizsrk edited edge metadata.Oct 7 2016, 7:41 AM
This revision was automatically updated to reflect the committed changes.