HomePhabricator

Improve autofixing of double quotes in XHPAST linter.

Description

Improve autofixing of double quotes in XHPAST linter.

Summary: The XHPAST double quotes rule autofixes strings which use double quotes where single quotes would suffice. In the case in which the double-quoted string contained an escaped double quote, the autofix string can be improved by removing the escape symbol.

Test Plan: Modified existing unit tests to cover this case.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9196

Details

Provenance
joshuaspenceAuthored on
epriestleyCommitted on May 19 2014, 2:49 PM
epriestleyPushed on May 19 2014, 2:49 PM
Reviewer
Blessed Reviewers
Differential Revision
D9196: Improve autofixing of double quotes in XHPAST linter.
Parents
rARCb251615716b3: Add a rule to the XHPAST linter to check for whitespace before a semicolon.
Branches
Unknown
Tags
Unknown

Event Timeline