Page MenuHomePhabricator

Improve autofixing of double quotes in XHPAST linter.
ClosedPublic

Authored by joshuaspence on May 19 2014, 1:58 PM.
Tags
None
Referenced Files
F14023955: D9196.diff
Thu, Nov 7, 4:26 AM
F13973798: D9196.diff
Fri, Oct 18, 2:46 AM
Unknown Object (File)
Sep 6 2024, 6:50 PM
Unknown Object (File)
Sep 1 2024, 9:15 AM
Unknown Object (File)
Sep 1 2024, 9:15 AM
Unknown Object (File)
Sep 1 2024, 9:15 AM
Unknown Object (File)
Sep 1 2024, 9:08 AM
Unknown Object (File)
Aug 27 2024, 6:10 AM
Subscribers

Details

Summary

The XHPAST double quotes rule autofixes strings which use double quotes where single quotes would suffice. In the case in which the double-quoted string contained an escaped double quote, the autofix string can be improved by removing the escape symbol.

Test Plan

Modified existing unit tests to cover this case.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Improve autofixing of double quotes in XHPAST linter..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 2:49 PM
epriestley updated this revision to Diff 21841.

Closed by commit rARC1b0ab48f15d4 (authored by @joshuaspence, committed by @epriestley).