Switch file uploader in "arc diff" to use ConduitEngine
18799c182921
Actions

Description

Switch file uploader in "arc diff" to use ConduitEngine

Summary: Fixes T13498. Currently, arc diff may invoke the file upload flow using an older variation of the API. Both the modern and fallback clients build an Engine, so switching to the modern API is trivial.

Test Plan:

Created a local commit with a 1MB binary file.
Ran arc diff --only.
Before patch: fatal on old API call.
After patch: clean upload.

Maniphest Tasks: T13498

Differential Revision: https://secure.phabricator.com/D21043

Details

Provenance

epriestley	Authored on Mar 20 2020, 7:15 PM
epriestley	Pushed on Mar 20 2020, 7:19 PM

Differential Revision

D21043: Switch file uploader in "arc diff" to use ConduitEngine

Parents

rARC97e050fce7a5: Use a named remote and branches for staging to help git-lfs

Branches

Unknown

Tags

Unknown

Tasks

T13498: "arc diff" may fail with Toolsets code when trying to build a ConduitEngine to upload files

Build Status

Buildable 23950
Build 32959: Run Core Tests

Event Timeline

epriestley committed rARC18799c182921: Switch file uploader in "arc diff" to use ConduitEngine (authored by epriestley).Mar 20 2020, 7:19 PM

epriestley added a task: T13498: "arc diff" may fail with Toolsets code when trying to build a ConduitEngine to upload files .

epriestley added an edge: D21043: Switch file uploader in "arc diff" to use ConduitEngine.

Harbormaster completed building B23950: rARC18799c182921: Switch file uploader in "arc diff" to use ConduitEngine.Mar 20 2020, 7:19 PM

tycho.tatitscheff added a subscriber: tycho.tatitscheff.Apr 28 2020, 9:51 AM

Changes (2)

Path

Size

src/

upload/

ArcanistFileUploader.php

workflow/

ArcanistDiffWorkflow.php

rARC18799c182921

View Options

src/upload/ArcanistFileUploader.php