Page MenuHomePhabricator

Switch file uploader in "arc diff" to use ConduitEngine
ClosedPublic

Authored by epriestley on Fri, Mar 20, 7:18 PM.

Details

Summary

Fixes T13498. Currently, arc diff may invoke the file upload flow using an older variation of the API. Both the modern and fallback clients build an Engine, so switching to the modern API is trivial.

Test Plan
  • Created a local commit with a 1MB binary file.
  • Ran arc diff --only.
  • Before patch: fatal on old API call.
  • After patch: clean upload.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, Mar 20, 7:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Mar 20, 7:19 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.