Page MenuHomePhabricator

Switch file uploader in "arc diff" to use ConduitEngine
ClosedPublic

Authored by epriestley on Mar 20 2020, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 2:00 PM
Unknown Object (File)
Sun, Dec 8, 4:55 AM
Unknown Object (File)
Fri, Dec 6, 1:16 PM
Unknown Object (File)
Thu, Dec 5, 1:56 AM
Unknown Object (File)
Oct 16 2024, 2:44 AM
Unknown Object (File)
Oct 15 2024, 2:57 AM
Unknown Object (File)
Sep 5 2024, 1:28 AM
Unknown Object (File)
Sep 3 2024, 9:31 AM
Subscribers
None

Details

Summary

Fixes T13498. Currently, arc diff may invoke the file upload flow using an older variation of the API. Both the modern and fallback clients build an Engine, so switching to the modern API is trivial.

Test Plan
  • Created a local commit with a 1MB binary file.
  • Ran arc diff --only.
  • Before patch: fatal on old API call.
  • After patch: clean upload.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 20 2020, 7:19 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.