Page MenuHomePhabricator

"arc diff" may fail with Toolsets code when trying to build a ConduitEngine to upload files
Closed, ResolvedPublic

Description

See https://discourse.phabricator-community.org/t/undefined-method-arcanistfileuploader-setconduitclient-when-creating-a-diff/3599.

Some pathways in arc diff end up engaging a file uploader flow, but the flow now relies on a ConduitEngine rather than the older ConduitClient. This can produce an error like this one:

EXCEPTION: (Error) Call to undefined method ArcanistFileUploader::setConduitClient() at ...

I suspect the cleanest fix is to have the fallback mode of arc build both a Client and an Engine; this is likely straightforward.

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley triaged this task as Normal priority.Mar 6 2020, 5:10 PM
epriestley created this task.
epriestley added a revision: Restricted Differential Revision.Mar 20 2020, 7:18 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Mar 20 2020, 7:19 PM
epriestley added a commit: Restricted Diffusion Commit.