When can this diff be landed?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Nov 24 2017
Nov 24 2017
Sep 25 2017
Sep 25 2017
When will this be landed?
Mar 16 2017
Mar 16 2017
thaiphv added a comment to D17232: Improve `ArcanistDeprecationXHPASTLinterRule` by lowercasing keys in `xhpast.deprecated.functions`.
Can this be reviewed again and landed?
Feb 13 2017
Feb 13 2017
thaiphv updated the diff for D17232: Improve `ArcanistDeprecationXHPASTLinterRule` by lowercasing keys in `xhpast.deprecated.functions`.
- Move the lowercasing logic into ArcanistXHPASTLinterRule::getFunctionCalls
Jan 22 2017
Jan 22 2017
thaiphv updated the diff for D17232: Improve `ArcanistDeprecationXHPASTLinterRule` by lowercasing keys in `xhpast.deprecated.functions`.
- Use CaseInsensitiveArray to store xhpast.deprecated.functions
- Fix jshint.lint-test
Jan 19 2017
Jan 19 2017
Nov 15 2016
Nov 15 2016
thaiphv updated the test plan for D16875: Ensure that `PHUIInvisibleCharacterTestCase` is compatible with PHP 5.3.
thaiphv retitled D16875: Ensure that `PHUIInvisibleCharacterTestCase` is compatible with PHP 5.3 from to Ensure that `PHUIInvisibleCharacterTestCase` is compatible with PHP 5.3.
Mar 21 2016
Mar 21 2016
Can someone please review and accept this fix?
Sep 25 2015
Sep 25 2015
thaiphv added a comment to D14107: Fix wrong indentation returned by AASTNode::getIndentation() when calling it on a statement node that is preceded by a comment token..
I've tested the function myself use the cases below:
thaiphv added a comment to D14107: Fix wrong indentation returned by AASTNode::getIndentation() when calling it on a statement node that is preceded by a comment token..
I'm not sure if PhutilTestCase supports testing abstract classes like this one.
thaiphv updated the diff for D14107: Fix wrong indentation returned by AASTNode::getIndentation() when calling it on a statement node that is preceded by a comment token..
Fix the review comment.
Sep 15 2015
Sep 15 2015
thaiphv updated the diff for D14107: Fix wrong indentation returned by AASTNode::getIndentation() when calling it on a statement node that is preceded by a comment token..
- Ensure that a next token is available
thaiphv retitled D14107: Fix wrong indentation returned by AASTNode::getIndentation() when calling it on a statement node that is preceded by a comment token. from to Fix wrong indentation returned by AASTNode::getIndentation() when calling it on a statement node that is preceded by a comment token..