Fix incorrect variable for linter standards
ClosedPublic
Actions

Authored by joshuaspence on Feb 8 2016, 4:17 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCea6fc7789295: Fix incorrect variable for linter standards

Summary

It is currently not possible to apply multiple linter standards because $value was used instead of $standard.

Test Plan

Was able to apply multiple linter standards.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 36720.Feb 8 2016, 4:17 AM

joshuaspence retitled this revision from to Fix incorrect variable for linter standards.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 8 2016, 4:17 AM

Herald added a subscriber: Korvin. · View Herald Transcript

Can someone please review and accept this fix?

The unit tests failed. Have you looked into why?

epriestley accepted this revision.Mar 21 2016, 5:12 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 21 2016, 5:12 PM

That puppet thing is some version issue in the vein of T9456.

Closed by commit rARCea6fc7789295: Fix incorrect variable for linter standards (authored by joshuaspence, committed by eadler). · Explain WhyApr 29 2016, 8:00 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistLinter.php

6 lines

Diff 38104

View Options

src/lint/linter/ArcanistLinter.php

Fix incorrect variable for linter standardsClosedPublicActions