Page MenuHomePhabricator

Make "metamta.differential.inline-patches" imply a reasonable byte limit, not just a line limit
ClosedPublic

Authored by epriestley on Oct 17 2016, 10:30 PM.

Details

Summary

Fixes T11748. This option currently implies a line limit (e.g., inline patches that are less than 100 lines long). This breaks down if a diff has a 10MB line, like a huge blob of JSON all on one line.

For now, imply a reasonable byte limit (256 bytes per line).

See T11767 for future work to make this and related options more cohesive.

Test Plan
  • With option at 1000: sent Differential email, saw patches inlined.
  • With option at 10: sent Differential email, saw patches dropped because of the byte limit.
  • var_dump()'d the actual limits and used bin/worker execute --id ... to sanity check that things were working properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make "metamta.differential.inline-patches" imply a reasonable byte limit, not just a line limit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 17 2016, 10:55 PM
This revision was automatically updated to reflect the committed changes.