Page MenuHomePhabricator
Feed Advanced Search

Apr 25 2017

chad closed T12636: Legalpad error view is missing some margins/padding as Resolved by committing rP9509bd1c7f2e: Fix legalpad error display.
Apr 25 2017, 4:28 PM · Legal, Design
chad added a revision to T12636: Legalpad error view is missing some margins/padding: D17789: Fix legalpad error display.
Apr 25 2017, 4:26 PM · Legal, Design

Apr 24 2017

epriestley created T12636: Legalpad error view is missing some margins/padding.
Apr 24 2017, 4:07 PM · Legal, Design

Sep 10 2014

epriestley added a comment to T6052: Legal links visible in all pages.

Let us know if you hit weird cases with this.

Sep 10 2014, 10:49 PM · Wikimedia, Legal
chasemp added a comment to T6052: Legal links visible in all pages.

Thanks @epriestley!

Sep 10 2014, 10:10 PM · Wikimedia, Legal
epriestley closed T6052: Legal links visible in all pages as Resolved.

Closed by commit rPd3cd9115f949.

Sep 10 2014, 9:44 PM · Wikimedia, Legal
epriestley added a revision to T6052: Legal links visible in all pages: D10466: Add `ui.footer-items` to add a custom page footer.
Sep 10 2014, 8:19 PM · Wikimedia, Legal
epriestley claimed T6052: Legal links visible in all pages.
Sep 10 2014, 7:21 PM · Wikimedia, Legal
epriestley added a comment to T6052: Legal links visible in all pages.

From discussion on IRC, there's some legal stuff that we should probably comply with too so I'll just implement this in the upstream and we can ride out the long tail of weird special cases.

Sep 10 2014, 7:20 PM · Wikimedia, Legal

Sep 9 2014

qgil added a comment to T6052: Legal links visible in all pages.

footer.html + float: right; sounds like a good enough solution for Wikimedia and other public Phabricator instances. If there is a way not to display the footer where it doesn't look good (workboards etc), I believe that would be fine too. The main spots for these disclaimers are the big bunch of project, task, and diff pages.

Sep 9 2014, 6:50 AM · Wikimedia, Legal
hach-que added a comment to T6052: Legal links visible in all pages.

In hindsight, welcome.html was a bad move and never saw significant use (at least on our installs). Once dashboards came out, we just installed a dashboard for every user and never went back.

Sep 9 2014, 4:50 AM · Wikimedia, Legal

Sep 8 2014

chad added a comment to T6052: Legal links visible in all pages.

Probably slap a float: right; and it'd be fine except maybe conpherence, workboards.

Sep 8 2014, 11:34 PM · Wikimedia, Legal
epriestley added a comment to T6052: Legal links visible in all pages.

We're going to remove welcome.html (T5315 / D9672) once dashboards are a little further along.

Sep 8 2014, 11:30 PM · Wikimedia, Legal
chasemp added a comment to T6052: Legal links visible in all pages.

footer.html was the first thing I looked for after feeling pretty pleased with welcome.html fwiw

Sep 8 2014, 11:04 PM · Wikimedia, Legal
chad added a comment to T6052: Legal links visible in all pages.

I wonder if we could allow a footer.html like we allowed welcome.html. Pages then on Phabricator could state whether they show a footer or not (like workboards). From browsing a few major sites, it doesn't seem like this information is on every last page, just most of them. I don't know that an icon in the header is sufficient.

Sep 8 2014, 10:50 PM · Wikimedia, Legal
epriestley added a comment to T6052: Legal links visible in all pages.

I guess is a bit legal-ish, and maybe .

Sep 8 2014, 9:24 PM · Wikimedia, Legal
epriestley updated subscribers of T6052: Legal links visible in all pages.

Downsides to the header approach are:

Sep 8 2014, 9:22 PM · Wikimedia, Legal
epriestley added a comment to T6052: Legal links visible in all pages.

Erp, jumped the gun on that, continued...

Sep 8 2014, 9:13 PM · Wikimedia, Legal
epriestley added a comment to T6052: Legal links visible in all pages.

You are the first install to run into this that we've heard from.

Sep 8 2014, 9:12 PM · Wikimedia, Legal
qgil moved T6052: Legal links visible in all pages from Backlog to Important on the Wikimedia board.
Sep 8 2014, 8:48 PM · Wikimedia, Legal
qgil created T6052: Legal links visible in all pages.
Sep 8 2014, 8:48 PM · Wikimedia, Legal