Page MenuHomePhabricator

Provide a simple "Attach File" explicit workflow for files referenced but not attached
ClosedPublic

Authored by epriestley on May 24 2022, 1:12 AM.
Tags
None
Referenced Files
F22655216: D21837.diff
Thu, Oct 1, 2:55 AM
F22644349: D21837.id52048.diff
Wed, Sep 30, 3:58 PM
Unknown Object (File)
Aug 26 2026, 11:57 AM
Unknown Object (File)
Aug 24 2026, 2:34 PM
Unknown Object (File)
Aug 16 2026, 5:36 AM
Unknown Object (File)
Aug 14 2026, 6:34 PM
Unknown Object (File)
Aug 14 2026, 4:21 PM
Unknown Object (File)
Aug 13 2026, 3:17 PM
Subscribers
None

Details

Summary

Ref T13682. Allow users to manually attach files which are referenced (but not attached) via the UI.

Test Plan

Reference files via {F...}, then attached them via the UI workflow.

Diff Detail

Repository
rP Phabricator
Branch
filex1
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25743
Build 35571: arc lint + arc unit

Unit TestsFailed

TimeTest
121 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
0 msPHUIInvisibleCharacterTestCase::testEmptyPlainText
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testEmptyString
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testHtmlDecoration
5 assertions passed.
0 msPHUIInvisibleCharacterTestCase::testWithHexChars
1 assertion passed.
View Full Test Results (1 Failed · 52 Passed)