Page MenuHomePhabricator

Provide a simple "Attach File" explicit workflow for files referenced but not attached
ClosedPublic

Authored by epriestley on May 24 2022, 1:12 AM.
Tags
None
Referenced Files
F19725991: D21837.diff
Fri, Feb 13, 5:10 PM
F19681363: D21837.id52047.diff
Sun, Feb 8, 9:38 PM
F19575930: D21837.id52049.diff
Sun, Feb 1, 8:04 AM
F19542272: D21837.id52046.diff
Thu, Jan 22, 8:29 AM
F19512862: D21837.diff
Jan 13 2026, 3:55 AM
F19455272: D21837.id.diff
Dec 31 2025, 8:17 AM
F19303768: D21837.id52049.diff
Dec 24 2025, 5:33 AM
F19303438: D21837.id52048.diff
Dec 24 2025, 12:45 AM
Subscribers
None

Details

Summary

Ref T13682. Allow users to manually attach files which are referenced (but not attached) via the UI.

Test Plan

Reference files via {F...}, then attached them via the UI workflow.

Diff Detail

Repository
rP Phabricator
Branch
filex1
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25743
Build 35571: arc lint + arc unit

Unit TestsFailed

TimeTest
121 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
0 msPHUIInvisibleCharacterTestCase::testEmptyPlainText
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testEmptyString
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testHtmlDecoration
5 assertions passed.
0 msPHUIInvisibleCharacterTestCase::testWithHexChars
1 assertion passed.
View Full Test Results (1 Failed · 52 Passed)