Page MenuHomePhabricator

Provide a simple "Attach File" explicit workflow for files referenced but not attached
ClosedPublic

Authored by epriestley on May 24 2022, 1:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 4:22 AM
Unknown Object (File)
Sat, Mar 23, 6:57 PM
Unknown Object (File)
Fri, Mar 22, 9:57 PM
Unknown Object (File)
Thu, Mar 21, 5:50 AM
Unknown Object (File)
Tue, Mar 19, 5:31 PM
Unknown Object (File)
Sat, Mar 16, 6:52 PM
Unknown Object (File)
Sat, Mar 16, 12:05 PM
Unknown Object (File)
Wed, Mar 13, 10:06 PM
Subscribers
None

Details

Summary

Ref T13682. Allow users to manually attach files which are referenced (but not attached) via the UI.

Test Plan

Reference files via {F...}, then attached them via the UI workflow.

Diff Detail

Repository
rP Phabricator
Branch
filex1
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25743
Build 35571: arc lint + arc unit

Unit TestsFailed

TimeTest
121 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
0 msPHUIInvisibleCharacterTestCase::testEmptyPlainText
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testEmptyString
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testHtmlDecoration
5 assertions passed.
0 msPHUIInvisibleCharacterTestCase::testWithHexChars
1 assertion passed.
View Full Test Results (1 Failed · 52 Passed)