Page MenuHomePhabricator

Provide a simple "Attach File" explicit workflow for files referenced but not attached
ClosedPublic

Authored by epriestley on May 24 2022, 1:12 AM.
Tags
None
Referenced Files
F18843392: D21837.id52047.diff
Tue, Oct 28, 9:50 PM
F18818097: D21837.id.diff
Tue, Oct 21, 8:52 PM
F18812840: D21837.id52049.diff
Mon, Oct 20, 12:36 PM
F18812829: D21837.id52047.diff
Mon, Oct 20, 12:36 PM
F18811995: D21837.id52047.diff
Mon, Oct 20, 6:21 AM
F18803489: D21837.id52048.diff
Sat, Oct 18, 12:32 AM
F18726379: D21837.diff
Sep 30 2025, 6:34 AM
F18702654: D21837.id52048.diff
Sep 28 2025, 12:51 AM
Subscribers
None

Details

Summary

Ref T13682. Allow users to manually attach files which are referenced (but not attached) via the UI.

Test Plan

Reference files via {F...}, then attached them via the UI workflow.

Diff Detail

Repository
rP Phabricator
Branch
filex1
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25743
Build 35571: arc lint + arc unit

Unit TestsFailed

TimeTest
121 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
0 msPHUIInvisibleCharacterTestCase::testEmptyPlainText
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testEmptyString
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testHtmlDecoration
5 assertions passed.
0 msPHUIInvisibleCharacterTestCase::testWithHexChars
1 assertion passed.
View Full Test Results (1 Failed · 52 Passed)