Page MenuHomePhabricator

Provide a simple "Attach File" explicit workflow for files referenced but not attached
ClosedPublic

Authored by epriestley on May 24 2022, 1:12 AM.
Tags
None
Referenced Files
F18284150: D21837.id52049.diff
Sat, Aug 23, 3:52 AM
F18283585: D21837.id52047.diff
Sat, Aug 23, 1:36 AM
F18283449: D21837.id52046.diff
Sat, Aug 23, 1:23 AM
F18270474: D21837.id52048.diff
Fri, Aug 22, 3:32 PM
F18234887: D21837.id.diff
Wed, Aug 20, 6:48 PM
F18234876: D21837.id52049.diff
Wed, Aug 20, 6:47 PM
F18234851: D21837.id52048.diff
Wed, Aug 20, 6:44 PM
F18234788: D21837.id52046.diff
Wed, Aug 20, 6:37 PM
Subscribers
None

Details

Summary

Ref T13682. Allow users to manually attach files which are referenced (but not attached) via the UI.

Test Plan

Reference files via {F...}, then attached them via the UI workflow.

Diff Detail

Repository
rP Phabricator
Branch
filex1
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25743
Build 35571: arc lint + arc unit

Unit TestsFailed

TimeTest
121 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
0 msPHUIInvisibleCharacterTestCase::testEmptyPlainText
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testEmptyString
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testHtmlDecoration
5 assertions passed.
0 msPHUIInvisibleCharacterTestCase::testWithHexChars
1 assertion passed.
View Full Test Results (1 Failed · 52 Passed)