Paths

Table of Contentst

Differential D21837

Provide a simple "Attach File" explicit workflow for files referenced but not attached
ClosedPublic
Actions

Authored by epriestley on May 24 2022, 1:12 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 4, 7:32 PM

	Unknown Object (File)
	Sat, May 4, 10:36 AM

	Unknown Object (File)
	Fri, May 3, 9:26 AM

	Unknown Object (File)
	Thu, May 2, 11:21 AM

	Unknown Object (File)
	Thu, May 2, 11:21 AM

	Unknown Object (File)
	Thu, May 2, 4:26 AM

	Unknown Object (File)
	Wed, May 1, 12:10 AM

	Unknown Object (File)
	Tue, Apr 30, 8:41 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rP5493f028dca6: Provide a simple "Attach File" explicit workflow for files referenced but not…

Summary

Ref T13682. Allow users to manually attach files which are referenced (but not attached) via the UI.

Test Plan

Reference files via {F...}, then attached them via the UI workflow.

Diff Detail

Repository

Branch

filex1

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1144	XHP54	Formatted String
Error	src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1150	XHP54	Formatted String

Unit

Test Failures

Build Status

Buildable 25742
Build 35570: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	126 ms	PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
	0 ms	PHUIInvisibleCharacterTestCase::testEmptyPlainText 1 assertion passed.
	0 ms	PHUIInvisibleCharacterTestCase::testEmptyString 1 assertion passed.
	0 ms	PHUIInvisibleCharacterTestCase::testHtmlDecoration 5 assertions passed.
	0 ms	PHUIInvisibleCharacterTestCase::testWithHexChars 1 assertion passed.
		View Full Test Results (1 Failed · 52 Passed)

Event Timeline

epriestley requested review of this revision.May 24 2022, 1:12 AM

epriestley created this revision.

Harbormaster completed remote builds in B25742: Diff 52046.May 24 2022, 1:12 AM

Correct some translation strings.

Harbormaster completed remote builds in B25743: Diff 52047.May 24 2022, 1:13 AM

Rebuild Celerity map.

Harbormaster completed remote builds in B25744: Diff 52048.May 24 2022, 1:13 AM

This revision was not accepted when it landed; it landed in state Needs Review.May 24 2022, 4:50 PM

Closed by commit rP5493f028dca6: Provide a simple "Attach File" explicit workflow for files referenced but not… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5493f028dca6: Provide a simple "Attach File" explicit workflow for files referenced but not….

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

base/

controller/

PhabricatorController.php

4 lines

files/

application/

PhabricatorFilesApplication.php

10 lines

controller/

PhabricatorFileUICurtainAttachController.php

136 lines

PhabricatorFileUICurtainListController.php

2 lines

engineextension/

PhabricatorFilesCurtainExtension.php

50 lines

phid/

PhabricatorFileFilePHIDType.php

3 lines

query/

PhabricatorFileAttachmentQuery.php

25 lines

storage/

PhabricatorFileAttachment.php

9 lines

policy/

storage/

PhabricatorPolicy.php

15 lines

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

1 line

storage/

PhabricatorApplicationTransaction.php

195 lines

infrastructure/

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

14 lines

view/

phui/

PHUICurtainObjectRefView.php

12 lines

webroot/

rsrc/

css/

phui/

phui-curtain-object-ref-view.css

3 lines

Diff 52046

src/__phutil_library_map__.php

Loading...

src/applications/base/controller/PhabricatorController.php

Loading...

src/applications/files/application/PhabricatorFilesApplication.php

Loading...

src/applications/files/controller/PhabricatorFileUICurtainAttachController.php

Loading...

src/applications/files/controller/PhabricatorFileUICurtainListController.php

Loading...

src/applications/files/engineextension/PhabricatorFilesCurtainExtension.php

Loading...

src/applications/files/phid/PhabricatorFileFilePHIDType.php

Loading...

src/applications/files/query/PhabricatorFileAttachmentQuery.php

Loading...

src/applications/files/storage/PhabricatorFileAttachment.php

Loading...

src/applications/policy/storage/PhabricatorPolicy.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...

src/view/phui/PHUICurtainObjectRefView.php

Loading...

webroot/rsrc/css/phui/phui-curtain-object-ref-view.css

Loading...