Page MenuHomePhabricator

Provide a simple "Attach File" explicit workflow for files referenced but not attached
ClosedPublic

Authored by epriestley on May 24 2022, 1:12 AM.
Tags
None
Referenced Files
F15504954: D21837.id52047.diff
Mon, Apr 14, 10:52 PM
F15503019: D21837.diff
Mon, Apr 14, 6:07 AM
F15482896: D21837.id52047.diff
Wed, Apr 9, 8:34 AM
F15457106: D21837.diff
Sun, Mar 30, 2:23 PM
F15451756: D21837.id52049.diff
Fri, Mar 28, 11:39 PM
F15451739: D21837.id52048.diff
Fri, Mar 28, 11:36 PM
F15451723: D21837.id52047.diff
Fri, Mar 28, 11:32 PM
F15451711: D21837.id.diff
Fri, Mar 28, 11:28 PM
Subscribers
None

Details

Summary

Ref T13682. Allow users to manually attach files which are referenced (but not attached) via the UI.

Test Plan

Reference files via {F...}, then attached them via the UI workflow.

Diff Detail

Repository
rP Phabricator
Branch
filex1
Lint
Lint Errors
Unit
Test Failures
Build Status
Buildable 25742
Build 35570: arc lint + arc unit

Unit TestsFailed

TimeTest
126 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
0 msPHUIInvisibleCharacterTestCase::testEmptyPlainText
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testEmptyString
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testHtmlDecoration
5 assertions passed.
0 msPHUIInvisibleCharacterTestCase::testWithHexChars
1 assertion passed.
View Full Test Results (1 Failed · 52 Passed)