Page MenuHomePhabricator

Provide a simple "Attach File" explicit workflow for files referenced but not attached
ClosedPublic

Authored by epriestley on May 24 2022, 1:12 AM.
Tags
None
Referenced Files
F19303768: D21837.id52049.diff
Wed, Dec 24, 5:33 AM
F19303438: D21837.id52048.diff
Wed, Dec 24, 12:45 AM
F19303352: D21837.id52047.diff
Tue, Dec 23, 11:35 PM
F19239359: D21837.diff
Sun, Dec 21, 8:48 PM
F19153820: D21837.diff
Thu, Dec 11, 12:16 PM
F19105454: D21837.id.diff
Sat, Dec 6, 4:30 AM
F18904934: D21837.id52046.diff
Nov 8 2025, 11:58 AM
F18877022: D21837.diff
Nov 6 2025, 5:33 AM
Subscribers
None

Details

Summary

Ref T13682. Allow users to manually attach files which are referenced (but not attached) via the UI.

Test Plan

Reference files via {F...}, then attached them via the UI workflow.

Diff Detail

Repository
rP Phabricator
Branch
filex1
Lint
Lint Errors
Unit
Test Failures
Build Status
Buildable 25742
Build 35570: arc lint + arc unit

Unit TestsFailed

TimeTest
126 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
0 msPHUIInvisibleCharacterTestCase::testEmptyPlainText
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testEmptyString
1 assertion passed.
0 msPHUIInvisibleCharacterTestCase::testHtmlDecoration
5 assertions passed.
0 msPHUIInvisibleCharacterTestCase::testWithHexChars
1 assertion passed.
View Full Test Results (1 Failed · 52 Passed)