Page MenuHomePhabricator
Differential D21772

Remove product literal strings in "pht()", part 8
ClosedPublic
Actions

Authored by epriestley on Apr 25 2022, 7:09 PM.
Tags
None
Referenced Files
F19928177: D21772.id51908.diff
Wed, Apr 8, 9:27 AM
F19815159: D21772.id51908.diff
Mar 4 2026, 6:42 PM
F19812434: D21772.id51908.diff
Mar 4 2026, 4:59 AM
F19811951: D21772.id51908.diff
Mar 4 2026, 3:06 AM
F19807517: D21772.id51908.diff
Mar 3 2026, 3:25 AM
F19802224: D21772.id51895.diff
Mar 1 2026, 2:43 PM
F19494124: D21772.diff
Jan 8 2026, 9:29 AM
F19467915: D21772.diff
Jan 3 2026, 7:35 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13658: How to rebrand Phabricator
Commits
rP4d3f0dc7c727: Remove product literal strings in "pht()", part 8
Summary

Ref T13658.

Test Plan

This test plan is non-exhaustive.

  • Viewed "remarkup.process" Conduit method API page.
  • Viewed URIs in a Diffusion repository.
  • Viewed editor protocol configuration in Settings.

Diff Detail

Repository
rP Phabricator
Branch
product10
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/settings/setting/PhabricatorEmailStampsSetting.php:24XHP134Use of Product Name Literal
Unit
Tests Passed
Build Status
Buildable 25664
Build 35492: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.Apr 25 2022, 7:09 PM
epriestley created this revision.
Harbormaster completed remote builds in B25663: Diff 51894.Apr 25 2022, 7:09 PM
epriestley updated this revision to Diff 51895.Apr 25 2022, 7:10 PM
  • Additional PHP 8.1 "strlen(null)" fix.
Harbormaster completed remote builds in B25664: Diff 51895.Apr 25 2022, 7:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:23 PM
This revision was landed with ongoing or failed builds.
Closed by commit rP4d3f0dc7c727: Remove product literal strings in "pht()", part 8 (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP4d3f0dc7c727: Remove product literal strings in "pht()", part 8.

Revision Contents
Changeset List

Diff 51895

View Options

src/applications/remarkup/conduit/RemarkupProcessConduitAPIMethod.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryMirrorEngine.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementCacheWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...
View Options

src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php

Loading...
View Options

src/applications/settings/setting/PhabricatorEmailStampsSetting.php

Loading...
View Options

src/applications/settings/setting/PhabricatorTranslationSetting.php

Loading...
View Options

src/applications/system/controller/PhabricatorSystemReadOnlyController.php

Loading...
View Options

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility