Page MenuHomePhabricator

Remove product literal strings in "pht()", part 8
ClosedPublic

Authored by epriestley on Apr 25 2022, 7:09 PM.
Tags
None
Referenced Files
F12816339: D21772.diff
Thu, Mar 28, 3:37 AM
Unknown Object (File)
Sat, Mar 9, 12:53 PM
Unknown Object (File)
Thu, Mar 7, 1:24 AM
Unknown Object (File)
Feb 5 2024, 9:40 AM
Unknown Object (File)
Feb 4 2024, 5:07 PM
Unknown Object (File)
Feb 4 2024, 1:42 AM
Unknown Object (File)
Jan 19 2024, 7:03 AM
Unknown Object (File)
Jan 16 2024, 8:53 PM
Subscribers
None

Details

Summary

Ref T13658.

Test Plan

This test plan is non-exhaustive.

  • Viewed "remarkup.process" Conduit method API page.
  • Viewed URIs in a Diffusion repository.
  • Viewed editor protocol configuration in Settings.

Diff Detail

Repository
rP Phabricator
Branch
product10
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/settings/setting/PhabricatorEmailStampsSetting.php:24XHP134Use of Product Name Literal
Unit
Tests Passed
Build Status
Buildable 25664
Build 35492: arc lint + arc unit

Event Timeline

epriestley created this revision.
  • Additional PHP 8.1 "strlen(null)" fix.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:23 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.