Page MenuHomePhabricator

Remove product literal strings in "pht()", part 8
ClosedPublic

Authored by epriestley on Apr 25 2022, 7:09 PM.
Tags
None
Referenced Files
F11040151: D21772.diff
Tue, Aug 16, 7:26 AM
Unknown Object (File)
Mon, Aug 15, 8:10 PM
Unknown Object (File)
Fri, Aug 12, 3:33 PM
Unknown Object (File)
Fri, Aug 12, 10:51 AM
Unknown Object (File)
Wed, Aug 10, 3:52 PM
Unknown Object (File)
Wed, Aug 10, 1:31 PM
Unknown Object (File)
Sun, Jul 24, 4:14 AM
Unknown Object (File)
Sun, Jul 24, 4:14 AM
Subscribers
None

Details

Summary

Ref T13658.

Test Plan

This test plan is non-exhaustive.

  • Viewed "remarkup.process" Conduit method API page.
  • Viewed URIs in a Diffusion repository.
  • Viewed editor protocol configuration in Settings.

Diff Detail

Repository
rP Phabricator
Branch
product10
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/settings/setting/PhabricatorEmailStampsSetting.php:24XHP134Use of Product Name Literal
Unit
Test Failures
Build Status
Buildable 25663
Build 35491: arc lint + arc unit

Unit TestsFailed

TimeTest
27 msPhabricatorWorkingCopyDiscoveryTestCase::testGitCommitDiscovery
EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/repository/storage/PhabricatorRepository.php(206): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 206) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php(160): PhabricatorRepository->getDisplayName()
53 msPhabricatorWorkingCopyDiscoveryTestCase::testMercurialCommitDiscovery
EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/repository/storage/PhabricatorRepository.php(206): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 206) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php(160): PhabricatorRepository->getDisplayName()
25 msPhabricatorWorkingCopyPullTestCase::testGitPullBasic
EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/repository/storage/PhabricatorRepository.php(206): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 206) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php(160): PhabricatorRepository->getDisplayName()
32 msPhabricatorWorkingCopyPullTestCase::testHgPullBasic
EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/repository/storage/PhabricatorRepository.php(206): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 206) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php(160): PhabricatorRepository->getDisplayName()
26 msPhabricatorWorkingCopyPullTestCase::testSVNPullBasic
EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/repository/storage/PhabricatorRepository.php(206): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 206) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php(76): PhabricatorRepository->getDisplayName()
View Full Test Results (5 Failed · 14 Passed · 1 Skipped)

Event Timeline

epriestley created this revision.
  • Additional PHP 8.1 "strlen(null)" fix.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:23 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.