Page MenuHomePhabricator

Remove product literal strings in "pht()", part 8
ClosedPublic

Authored by epriestley on Apr 25 2022, 7:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 1, 7:55 AM
Unknown Object (File)
Fri, Jul 1, 7:54 AM
Unknown Object (File)
Fri, Jul 1, 7:54 AM
Unknown Object (File)
Fri, Jul 1, 7:54 AM
Unknown Object (File)
Wed, Jun 29, 9:21 AM
Unknown Object (File)
Mon, Jun 20, 9:18 AM
Unknown Object (File)
Thu, Jun 16, 10:10 AM
Unknown Object (File)
Thu, Jun 16, 10:10 AM
Subscribers
None

Details

Summary

Ref T13658.

Test Plan

This test plan is non-exhaustive.

  • Viewed "remarkup.process" Conduit method API page.
  • Viewed URIs in a Diffusion repository.
  • Viewed editor protocol configuration in Settings.

Diff Detail

Repository
rP Phabricator
Branch
product10
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/settings/setting/PhabricatorEmailStampsSetting.php:24XHP134Use of Product Name Literal
Unit
Tests Passed
Build Status
Buildable 25664
Build 35492: arc lint + arc unit

Event Timeline

epriestley created this revision.
  • Additional PHP 8.1 "strlen(null)" fix.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:23 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.