Paths

Table of Contentst

Differential D21770

Remove product literal strings in "pht()", part 6
ClosedPublic
Actions

Authored by epriestley on Apr 25 2022, 6:37 PM.

Details

Reviewers: None
Maniphest Tasks: T13658: How to rebrand Phabricator
Commits: rPb3557796fe65: Remove product literal strings in "pht()", part 6

Summary

Ref T13658.

Test Plan

This test plan is non-exhaustive.

Ran bin/mail.
Uninstalled and reinstalled an application.

Diff Detail

Repository

rP Phabricator

Branch

product8

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php:154	XHP134	Use of Product Name Literal

Unit

Tests Passed

Build Status

Buildable 25660
Build 35488: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 25 2022, 6:37 PM

Owners added a subscriber: Restricted Owners Package.Apr 25 2022, 6:37 PM

epriestley requested review of this revision.Apr 25 2022, 6:37 PM

Harbormaster completed remote builds in B25659: Diff 51890.Apr 25 2022, 6:37 PM

Additional PHP 8.1 "strlen(null)" fixes.

Harbormaster completed remote builds in B25660: Diff 51891.Apr 25 2022, 6:57 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:22 PM

This revision was landed with ongoing or failed builds.

Closed by commit rPb3557796fe65: Remove product literal strings in "pht()", part 6 (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb3557796fe65: Remove product literal strings in "pht()", part 6.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

query/

HarbormasterBuildPlanQuery.php

2 lines

step/

HarbormasterUploadArtifactBuildStepImplementation.php

2 lines

legalpad/

editor/

LegalpadDocumentEditEngine.php

2 lines

maniphest/

config/

PhabricatorManiphestConfigOptions.php

2 lines

meta/

controller/

PhabricatorApplicationUninstallController.php

11 lines

metamta/

adapter/

PhabricatorMailTestAdapter.php

4 lines

constants/

MetaMTAReceivedMailStatus.php

2 lines

controller/

PhabricatorMetaMTAMailViewController.php

2 lines

engine/

PhabricatorMailEmailEngine.php

26 lines

management/

PhabricatorMailManagementListInboundWorkflow.php

2 lines

PhabricatorMailManagementListOutboundWorkflow.php

2 lines

parser/

PhabricatorMetaMTAEmailBodyParser.php

1 line

storage/

PhabricatorMetaMTAReceivedMail.php

33 lines

__tests__/

PhabricatorMetaMTAMailTestCase.php

4 lines

util/

PhabricatorMailUtil.php

5 lines

settings/

setting/

PhabricatorEditorSetting.php

2 lines

PhabricatorSelectSetting.php

5 lines

infrastructure/

storage/

connection/

mysql/

AphrontBaseMySQLDatabaseConnection.php

1 line

Diff 51891

View Options

src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php

View Options

src/applications/harbormaster/step/HarbormasterUploadArtifactBuildStepImplementation.php

View Options

src/applications/legalpad/editor/LegalpadDocumentEditEngine.php

View Options

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

View Options

src/applications/meta/controller/PhabricatorApplicationUninstallController.php

View Options

src/applications/metamta/adapter/PhabricatorMailTestAdapter.php

View Options

src/applications/metamta/constants/MetaMTAReceivedMailStatus.php

View Options

src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php

View Options

src/applications/metamta/engine/PhabricatorMailEmailEngine.php

View Options

src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php

View Options

src/applications/metamta/management/PhabricatorMailManagementListOutboundWorkflow.php

View Options

src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php

View Options

src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php

View Options

src/applications/metamta/storage/tests/PhabricatorMetaMTAMailTestCase.php

View Options

src/applications/metamta/util/PhabricatorMailUtil.php

View Options

src/applications/settings/setting/PhabricatorEditorSetting.php

View Options

src/applications/settings/setting/PhabricatorSelectSetting.php

View Options

src/infrastructure/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php

Remove product literal strings in "pht()", part 6ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51891

src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php

src/applications/harbormaster/step/HarbormasterUploadArtifactBuildStepImplementation.php

src/applications/legalpad/editor/LegalpadDocumentEditEngine.php

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

src/applications/meta/controller/PhabricatorApplicationUninstallController.php

src/applications/metamta/adapter/PhabricatorMailTestAdapter.php

src/applications/metamta/constants/MetaMTAReceivedMailStatus.php

src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php

src/applications/metamta/engine/PhabricatorMailEmailEngine.php

src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php

src/applications/metamta/management/PhabricatorMailManagementListOutboundWorkflow.php

src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php

src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php

src/applications/metamta/storage/__tests__/PhabricatorMetaMTAMailTestCase.php

src/applications/metamta/util/PhabricatorMailUtil.php

src/applications/settings/setting/PhabricatorEditorSetting.php

src/applications/settings/setting/PhabricatorSelectSetting.php

src/infrastructure/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php

Remove product literal strings in "pht()", part 6
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/metamta/storage/tests/PhabricatorMetaMTAMailTestCase.php