Page MenuHomePhabricator
Differential D21770

Remove product literal strings in "pht()", part 6
ClosedPublic
Actions

Authored by epriestley on Apr 25 2022, 6:37 PM.
Tags
None
Referenced Files
F15455214: D21770.diff
Sat, Mar 29, 10:54 PM
F15454473: D21770.diff
Sat, Mar 29, 6:38 PM
F15434258: D21770.id51890.diff
Tue, Mar 25, 2:48 AM
F15430497: D21770.id51891.diff
Mon, Mar 24, 7:56 AM
F15428025: D21770.diff
Sun, Mar 23, 6:02 PM
F15412984: D21770.diff
Wed, Mar 19, 4:11 PM
F15400470: D21770.id51906.diff
Mon, Mar 17, 11:49 AM
F15392224: D21770.diff
Sat, Mar 15, 1:55 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13658: How to rebrand Phabricator
Commits
rPb3557796fe65: Remove product literal strings in "pht()", part 6
Summary

Ref T13658.

Test Plan

This test plan is non-exhaustive.

  • Ran bin/mail.
  • Uninstalled and reinstalled an application.

Diff Detail

Repository
rP Phabricator
Branch
product8
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/maniphest/config/PhabricatorManiphestConfigOptions.php:154XHP134Use of Product Name Literal
Unit
Tests Passed
Build Status
Buildable 25660
Build 35488: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 25 2022, 6:37 PM
Owners added a subscriber: Restricted Owners Package.Apr 25 2022, 6:37 PM
epriestley requested review of this revision.Apr 25 2022, 6:37 PM
Harbormaster completed remote builds in B25659: Diff 51890.Apr 25 2022, 6:37 PM
epriestley updated this revision to Diff 51891.Apr 25 2022, 6:57 PM
  • Additional PHP 8.1 "strlen(null)" fixes.
Harbormaster completed remote builds in B25660: Diff 51891.Apr 25 2022, 6:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:22 PM
This revision was landed with ongoing or failed builds.
Closed by commit rPb3557796fe65: Remove product literal strings in "pht()", part 6 (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPb3557796fe65: Remove product literal strings in "pht()", part 6.

Revision Contents
Changeset List

Diff 51891

View Options

src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterUploadArtifactBuildStepImplementation.php

Loading...
View Options

src/applications/legalpad/editor/LegalpadDocumentEditEngine.php

Loading...
View Options

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationUninstallController.php

Loading...
View Options

src/applications/metamta/adapter/PhabricatorMailTestAdapter.php

Loading...
View Options

src/applications/metamta/constants/MetaMTAReceivedMailStatus.php

Loading...
View Options

src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php

Loading...
View Options

src/applications/metamta/engine/PhabricatorMailEmailEngine.php

Loading...
View Options

src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php

Loading...
View Options

src/applications/metamta/management/PhabricatorMailManagementListOutboundWorkflow.php

Loading...
View Options

src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php

Loading...
View Options

src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php

Loading...
View Options

src/applications/metamta/storage/__tests__/PhabricatorMetaMTAMailTestCase.php

Loading...
View Options

src/applications/metamta/util/PhabricatorMailUtil.php

Loading...
View Options

src/applications/settings/setting/PhabricatorEditorSetting.php

Loading...
View Options

src/applications/settings/setting/PhabricatorSelectSetting.php

Loading...
View Options

src/infrastructure/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php

Loading...
Phabricator · Built by Phacility