Page MenuHomePhabricator

Remove product literal strings in "pht()", part 6
ClosedPublic

Authored by epriestley on Apr 25 2022, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 29, 9:19 AM
Unknown Object (File)
Thu, Jun 16, 10:10 AM
Unknown Object (File)
Thu, Jun 16, 10:09 AM
Unknown Object (File)
Thu, Jun 16, 10:09 AM
Unknown Object (File)
Thu, Jun 16, 10:09 AM
Unknown Object (File)
Wed, Jun 15, 9:30 PM
Unknown Object (File)
Mon, Jun 13, 1:32 PM
Unknown Object (File)
May 30 2022, 4:11 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13658.

Test Plan

This test plan is non-exhaustive.

  • Ran bin/mail.
  • Uninstalled and reinstalled an application.

Diff Detail

Repository
rP Phabricator
Branch
product8
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/maniphest/config/PhabricatorManiphestConfigOptions.php:154XHP134Use of Product Name Literal
Unit
Test Failures
Build Status
Buildable 25659
Build 35487: arc lint + arc unit

Unit TestsFailed

TimeTest
41 msHarbormasterAutotargetsTestCase::testGenerateHarbormasterAutotargets
EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php(101): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 101) #1 /Users/epriestley/dev/core/lib/phabricator/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php(484): HarbormasterBuildPlanQuery->buildWhereClauseParts(Object(AphrontMySQLiDatabaseConnection))
13 msPhabricatorMetaMTAMailTestCase::testMailSendFailures
EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/metamta/engine/PhabricatorMailEmailEngine.php(511): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 511) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/metamta/engine/PhabricatorMailEmailEngine.php(182): PhabricatorMailEmailEngine->newDefaultEmailAddress()
23 msPhabricatorMetaMTAMailTestCase::testMailSizeLimits
EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/metamta/engine/PhabricatorMailEmailEngine.php(511): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 511) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/metamta/engine/PhabricatorMailEmailEngine.php(182): PhabricatorMailEmailEngine->newDefaultEmailAddress()
15 msPhabricatorMetaMTAMailTestCase::testMailerFailover
EXCEPTION (PhutilAggregateException): Encountered multiple exceptions while transmitting mail. - RuntimeException: strlen(): Passing null to parameter #1 ($string) of type string is deprecated - RuntimeException: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
51 msPhabricatorMetaMTAMailTestCase::testRecipients
EXCEPTION (PhabricatorApplicationTransactionValidationException): Validation errors: - strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/metamta/storage/__tests__/PhabricatorMetaMTAMailTestCase.php(256): PhabricatorApplicationTransactionEditor->applyTransactions(Object(PhabricatorUserPreferences), Array)
View Full Test Results (9 Failed · 13 Passed)

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 25 2022, 6:37 PM
  • Additional PHP 8.1 "strlen(null)" fixes.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:22 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.