Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 2:12 PM
Unknown Object (File)
Wed, Feb 5, 3:25 AM
Unknown Object (File)
Mon, Feb 3, 3:44 AM
Unknown Object (File)
Thu, Jan 30, 4:07 AM
Unknown Object (File)
Mon, Jan 27, 4:07 AM
Unknown Object (File)
Thu, Jan 16, 2:35 AM
Unknown Object (File)
Mon, Jan 13, 12:17 AM
Unknown Object (File)
Jan 9 2025, 7:43 AM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable