Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
F20380876: D21714.diff
Sat, Jun 13, 1:25 AM
Unknown Object (File)
Thu, Jun 4, 4:30 AM
Unknown Object (File)
Apr 6 2026, 2:37 AM
Unknown Object (File)
Apr 2 2026, 10:46 AM
Unknown Object (File)
Mar 24 2026, 8:18 PM
Unknown Object (File)
Mar 24 2026, 8:18 PM
Unknown Object (File)
Mar 24 2026, 1:47 PM
Unknown Object (File)
Mar 18 2026, 10:52 PM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Branch
import
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25533
Build 35304: Run Core Tests
Build 35303: arc lint + arc unit