Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
F19516294: D21714.id.diff
Wed, Jan 14, 10:26 PM
F19514289: D21714.id51734.diff
Wed, Jan 14, 12:23 AM
F19513562: D21714.diff
Tue, Jan 13, 2:02 PM
F19387395: D21714.diff
Sat, Dec 27, 3:33 AM
F18852425: D21714.id51734.diff
Oct 31 2025, 8:54 AM
F18806977: D21714.diff
Oct 18 2025, 10:19 PM
F18734448: D21714.id.diff
Sep 30 2025, 10:54 PM
F18646327: D21714.id.diff
Sep 19 2025, 9:48 AM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Branch
import
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25533
Build 35304: Run Core Tests
Build 35303: arc lint + arc unit