Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
F15401212: D21714.id51734.diff
Mon, Mar 17, 4:19 PM
F15392426: D21714.diff
Sat, Mar 15, 3:08 PM
F15383849: D21714.id51734.diff
Fri, Mar 14, 6:09 PM
F15379763: D21714.id51734.diff
Thu, Mar 13, 11:15 PM
F15333759: D21714.id51734.diff
Sat, Mar 8, 4:37 AM
Unknown Object (File)
Sun, Mar 2, 7:42 PM
Unknown Object (File)
Fri, Feb 21, 11:29 AM
Unknown Object (File)
Wed, Feb 19, 3:17 PM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Branch
import
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25533
Build 35304: Run Core Tests
Build 35303: arc lint + arc unit