Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
F15468264: D21714.id.diff
Thu, Apr 3, 10:35 PM
F15464632: D21714.diff
Wed, Apr 2, 11:31 AM
F15458341: D21714.diff
Sun, Mar 30, 11:08 PM
F15455889: D21714.diff
Sun, Mar 30, 5:32 AM
F15433144: D21714.id51734.diff
Mon, Mar 24, 9:42 PM
F15428900: D21714.diff
Sun, Mar 23, 11:09 PM
F15401212: D21714.id51734.diff
Mon, Mar 17, 4:19 PM
F15392426: D21714.diff
Sat, Mar 15, 3:08 PM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Branch
import
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25533
Build 35304: Run Core Tests
Build 35303: arc lint + arc unit