Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
F18806977: D21714.diff
Sat, Oct 18, 10:19 PM
F18734448: D21714.id.diff
Tue, Sep 30, 10:54 PM
F18646327: D21714.id.diff
Sep 19 2025, 9:48 AM
F18599388: D21714.id51734.diff
Sep 13 2025, 7:19 AM
F18534601: D21714.diff
Sep 7 2025, 11:44 AM
F18483668: D21714.id.diff
Sep 3 2025, 4:32 PM
F18423364: D21714.diff
Aug 30 2025, 7:37 PM
F18383374: D21714.diff
Aug 28 2025, 10:58 PM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable