Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
F12838869: D21714.id51734.diff
Thu, Mar 28, 6:47 PM
F12826166: D21714.diff
Thu, Mar 28, 9:20 AM
Unknown Object (File)
Feb 22 2024, 12:57 PM
Unknown Object (File)
Feb 7 2024, 8:07 PM
Unknown Object (File)
Feb 4 2024, 1:21 AM
Unknown Object (File)
Jan 24 2024, 2:52 AM
Unknown Object (File)
Jan 20 2024, 4:41 PM
Unknown Object (File)
Jan 16 2024, 5:13 PM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable