Page MenuHomePhabricator

Fix subtype extension support check
ClosedPublic

Authored by 0 on Aug 20 2021, 6:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 5:47 PM
Unknown Object (File)
Sat, Apr 6, 5:22 PM
Unknown Object (File)
Sat, Apr 6, 11:05 AM
Unknown Object (File)
Sun, Mar 31, 3:42 PM
Unknown Object (File)
Thu, Mar 28, 6:47 PM
Unknown Object (File)
Thu, Mar 28, 9:20 AM
Unknown Object (File)
Feb 22 2024, 12:57 PM
Unknown Object (File)
Feb 7 2024, 8:07 PM
Subscribers

Details

Summary

Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan
  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable