Page MenuHomePhabricator

Modularize almost all Harbormaster build message workflows and UI/UX
ClosedPublic

Authored by epriestley on Jul 16 2021, 1:30 AM.
Tags
None
Referenced Files
F15459398: D21691.id51704.diff
Mon, Mar 31, 12:39 PM
F15456360: D21691.diff
Sun, Mar 30, 9:05 AM
F15455568: D21691.id51704.diff
Sun, Mar 30, 3:16 AM
F15432969: D21691.id.diff
Mon, Mar 24, 8:36 PM
F15426594: D21691.diff
Sun, Mar 23, 9:53 AM
F15393538: D21691.id51704.diff
Sat, Mar 15, 9:22 PM
F15392514: D21691.diff
Sat, Mar 15, 3:39 PM
F15380521: D21691.diff
Fri, Mar 14, 3:27 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. Push nearly all Harbormaster build message logic into the new per-message transaction classes.

Test Plan
  • Issued every message to Buildables.
  • Issued every message to Builds.
  • Looked at a big pile of error messages, couldn't find any typos.
  • Grepped for affected symbols, etc.
  • Ran bin/harbormaster restart ....

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 1:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
This revision was automatically updated to reflect the committed changes.