Page MenuHomePhabricator

Modularize almost all Harbormaster build message workflows and UI/UX
ClosedPublic

Authored by epriestley on Jul 16 2021, 1:30 AM.
Tags
None
Referenced Files
F18194715: D21691.id51704.diff
Sun, Aug 17, 11:52 AM
F18106561: D21691.diff
Sun, Aug 10, 11:08 PM
F18086260: D21691.id.diff
Tue, Aug 5, 8:35 PM
F18060363: D21691.diff
Mon, Aug 4, 11:46 AM
F17936839: D21691.id51704.diff
Thu, Jul 31, 12:35 AM
F17910127: D21691.id51704.diff
Tue, Jul 29, 2:38 PM
F17843721: D21691.diff
Jul 27 2025, 1:16 AM
Unknown Object (File)
May 28 2025, 6:32 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. Push nearly all Harbormaster build message logic into the new per-message transaction classes.

Test Plan
  • Issued every message to Buildables.
  • Issued every message to Builds.
  • Looked at a big pile of error messages, couldn't find any typos.
  • Grepped for affected symbols, etc.
  • Ran bin/harbormaster restart ....

Diff Detail

Repository
rP Phabricator
Branch
build8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25456
Build 35180: Run Core Tests
Build 35179: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 1:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
This revision was automatically updated to reflect the committed changes.