Page MenuHomePhabricator

Modularize almost all Harbormaster build message workflows and UI/UX
ClosedPublic

Authored by epriestley on Jul 16 2021, 1:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 9:51 PM
Unknown Object (File)
Tue, Nov 19, 5:25 PM
Unknown Object (File)
Sat, Nov 16, 7:06 AM
Unknown Object (File)
Mon, Nov 11, 10:16 PM
Unknown Object (File)
Sun, Nov 10, 8:02 AM
Unknown Object (File)
Fri, Nov 8, 11:46 AM
Unknown Object (File)
Thu, Nov 7, 10:59 PM
Unknown Object (File)
Sun, Nov 3, 5:58 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. Push nearly all Harbormaster build message logic into the new per-message transaction classes.

Test Plan
  • Issued every message to Buildables.
  • Issued every message to Builds.
  • Looked at a big pile of error messages, couldn't find any typos.
  • Grepped for affected symbols, etc.
  • Ran bin/harbormaster restart ....

Diff Detail

Repository
rP Phabricator
Branch
build8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25456
Build 35180: Run Core Tests
Build 35179: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 1:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
This revision was automatically updated to reflect the committed changes.