Page MenuHomePhabricator

Modularize almost all Harbormaster build message workflows and UI/UX

Authored by epriestley on Jul 16 2021, 1:30 AM.
Referenced Files
F11645030: D21691.diff
Wed, Mar 29, 12:47 PM
Unknown Object (File)
Tue, Mar 28, 10:10 AM
Unknown Object (File)
Mon, Mar 27, 5:34 AM
Unknown Object (File)
Sun, Mar 26, 4:58 AM
Unknown Object (File)
Wed, Mar 22, 9:54 AM
Unknown Object (File)
Tue, Feb 28, 3:53 PM
Unknown Object (File)
Feb 20 2023, 12:49 PM
Unknown Object (File)
Feb 16 2023, 8:25 AM
Restricted Owners Package



Ref T13072. Push nearly all Harbormaster build message logic into the new per-message transaction classes.

Test Plan
  • Issued every message to Buildables.
  • Issued every message to Builds.
  • Looked at a big pile of error messages, couldn't find any typos.
  • Grepped for affected symbols, etc.
  • Ran bin/harbormaster restart ....

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 1:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
This revision was automatically updated to reflect the committed changes.