Page MenuHomePhabricator

Improve consistency in use of "via", "objectPHID", and "containerPHID" parameters in repository workers
ClosedPublic

Authored by epriestley on Feb 1 2021, 7:44 PM.
Tags
None
Referenced Files
F18765694: D21532.diff
Tue, Oct 7, 12:34 PM
F18759253: D21532.id.diff
Mon, Oct 6, 2:41 AM
F18734380: D21532.id.diff
Tue, Sep 30, 10:53 PM
F18702326: D21532.id51259.diff
Sat, Sep 27, 11:39 PM
F18629988: D21532.id.diff
Sep 16 2025, 10:27 AM
F18621495: D21532.id51259.diff
Sep 15 2025, 8:31 AM
F18606345: D21532.id.diff
Sep 13 2025, 10:09 PM
F18597606: D21532.id51253.diff
Sep 13 2025, 3:18 AM
Subscribers
None

Details

Summary

Ref T13591. Improve how parameters are passed between commit worker tasks:

  • Always pass "via", to track where tasks came from.
  • Always provide "objectPHID" (with the commit PHID).
  • Always provide "containerPHID" (with the repository PHID).
Test Plan
  • Pushed a new commit.
  • Ran bin/repository pull + bin/repository discover, saw commit with all parameters.
  • Ran bin/worker execute ..., saw a Change worker and then a Publish worker with appropriate parameters.
  • Ran bin/repository reparse ... --background, saw workers queue with appropriate parameters.

Diff Detail

Repository
rP Phabricator
Branch
phase3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25067
Build 34587: Run Core Tests
Build 34586: arc lint + arc unit

Event Timeline

  • Include skips for SVN tests with no SVN on system.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 2 2021, 9:40 PM
This revision was automatically updated to reflect the committed changes.