Page MenuHomePhabricator

Improve consistency in use of "via", "objectPHID", and "containerPHID" parameters in repository workers
ClosedPublic

Authored by epriestley on Feb 1 2021, 7:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 30, 10:41 PM
Unknown Object (File)
May 31 2025, 2:51 AM
Unknown Object (File)
May 30 2025, 7:09 AM
Unknown Object (File)
May 30 2025, 12:59 AM
Unknown Object (File)
May 27 2025, 4:53 PM
Unknown Object (File)
Apr 29 2025, 4:51 AM
Unknown Object (File)
Apr 28 2025, 1:51 AM
Unknown Object (File)
Apr 26 2025, 9:46 PM
Subscribers
None

Details

Summary

Ref T13591. Improve how parameters are passed between commit worker tasks:

  • Always pass "via", to track where tasks came from.
  • Always provide "objectPHID" (with the commit PHID).
  • Always provide "containerPHID" (with the repository PHID).
Test Plan
  • Pushed a new commit.
  • Ran bin/repository pull + bin/repository discover, saw commit with all parameters.
  • Ran bin/worker execute ..., saw a Change worker and then a Publish worker with appropriate parameters.
  • Ran bin/repository reparse ... --background, saw workers queue with appropriate parameters.

Diff Detail

Repository
rP Phabricator
Branch
phase3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25067
Build 34587: Run Core Tests
Build 34586: arc lint + arc unit

Event Timeline

  • Include skips for SVN tests with no SVN on system.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 2 2021, 9:40 PM
This revision was automatically updated to reflect the committed changes.