Ref T13591. Improve how parameters are passed between commit worker tasks:
- Always pass "via", to track where tasks came from.
- Always provide "objectPHID" (with the commit PHID).
- Always provide "containerPHID" (with the repository PHID).
Details
Details
- Pushed a new commit.
- Ran bin/repository pull + bin/repository discover, saw commit with all parameters.
- Ran bin/worker execute ..., saw a Change worker and then a Publish worker with appropriate parameters.
- Ran bin/repository reparse ... --background, saw workers queue with appropriate parameters.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phase3
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 25066 Build 34585: Run Core Tests Build 34584: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 38 ms | PhabricatorChangeParserTestCase::testSubversionForeignStubsParser EXCEPTION (CommandException): Command failed with error #127!
COMMAND
svn --non-interactive info --xml file:///var/folders/72/x4dt4z152d79y3wf2khgbgtr0000gn/T/4uxd10u9v8kkwgk0
| |
| 34 ms | PhabricatorChangeParserTestCase::testSubversionParser EXCEPTION (CommandException): Command failed with error #127!
COMMAND
svn --non-interactive info --xml file:///var/folders/72/x4dt4z152d79y3wf2khgbgtr0000gn/T/7pzm2sy9zu8sk4ow
| |
| 28 ms | PhabricatorChangeParserTestCase::testSubversionPartialParser EXCEPTION (CommandException): Command failed with error #127!
COMMAND
svn --non-interactive info --xml file:///var/folders/72/x4dt4z152d79y3wf2khgbgtr0000gn/T/2xw0h2buthkwwok8
| |
| 30 ms | PhabricatorChangeParserTestCase::testSubversionValidRootParser Assertion failed, expected 'false' (at PhabricatorChangeParserTestCase.php:1079): Natural SVN root should work properly.
ACTUAL VALUE
| |
| 0 ms | AlmanacNamesTestCase::testServiceOrDeviceNames 30 assertions passed. | |
| View Full Test Results (4 Failed · 430 Passed · 6 Skipped) |