Page MenuHomePhabricator

Improve consistency in use of "via", "objectPHID", and "containerPHID" parameters in repository workers
ClosedPublic

Authored by epriestley on Feb 1 2021, 7:44 PM.

Details

Summary

Ref T13591. Improve how parameters are passed between commit worker tasks:

  • Always pass "via", to track where tasks came from.
  • Always provide "objectPHID" (with the commit PHID).
  • Always provide "containerPHID" (with the repository PHID).
Test Plan
  • Pushed a new commit.
  • Ran bin/repository pull + bin/repository discover, saw commit with all parameters.
  • Ran bin/worker execute ..., saw a Change worker and then a Publish worker with appropriate parameters.
  • Ran bin/repository reparse ... --background, saw workers queue with appropriate parameters.

Diff Detail

Repository
rP Phabricator
Branch
phase3
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25066
Build 34585: Run Core Tests
Build 34584: arc lint + arc unit

Unit TestsFailed

TimeTest
38 msPhabricatorChangeParserTestCase::testSubversionForeignStubsParser
EXCEPTION (CommandException): Command failed with error #127! COMMAND svn --non-interactive info --xml file:///var/folders/72/x4dt4z152d79y3wf2khgbgtr0000gn/T/4uxd10u9v8kkwgk0
34 msPhabricatorChangeParserTestCase::testSubversionParser
EXCEPTION (CommandException): Command failed with error #127! COMMAND svn --non-interactive info --xml file:///var/folders/72/x4dt4z152d79y3wf2khgbgtr0000gn/T/7pzm2sy9zu8sk4ow
28 msPhabricatorChangeParserTestCase::testSubversionPartialParser
EXCEPTION (CommandException): Command failed with error #127! COMMAND svn --non-interactive info --xml file:///var/folders/72/x4dt4z152d79y3wf2khgbgtr0000gn/T/2xw0h2buthkwwok8
30 msPhabricatorChangeParserTestCase::testSubversionValidRootParser
Assertion failed, expected 'false' (at PhabricatorChangeParserTestCase.php:1079): Natural SVN root should work properly. ACTUAL VALUE
0 msAlmanacNamesTestCase::testServiceOrDeviceNames
30 assertions passed.
View Full Test Results (4 Failed · 430 Passed · 6 Skipped)

Event Timeline

  • Include skips for SVN tests with no SVN on system.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 2 2021, 9:40 PM
This revision was automatically updated to reflect the committed changes.