Page MenuHomePhabricator

Improve consistency in use of "via", "objectPHID", and "containerPHID" parameters in repository workers
ClosedPublic

Authored by epriestley on Feb 1 2021, 7:44 PM.
Tags
None
Referenced Files
F13051908: D21532.id51253.diff
Fri, Apr 19, 5:35 AM
Unknown Object (File)
Mar 16 2024, 6:04 AM
Unknown Object (File)
Jan 25 2024, 2:31 AM
Unknown Object (File)
Jan 10 2024, 6:43 AM
Unknown Object (File)
Dec 27 2023, 8:52 PM
Unknown Object (File)
Nov 26 2023, 12:07 AM
Unknown Object (File)
Nov 17 2023, 12:27 PM
Unknown Object (File)
Nov 1 2023, 4:44 AM
Subscribers
None

Details

Summary

Ref T13591. Improve how parameters are passed between commit worker tasks:

  • Always pass "via", to track where tasks came from.
  • Always provide "objectPHID" (with the commit PHID).
  • Always provide "containerPHID" (with the repository PHID).
Test Plan
  • Pushed a new commit.
  • Ran bin/repository pull + bin/repository discover, saw commit with all parameters.
  • Ran bin/worker execute ..., saw a Change worker and then a Publish worker with appropriate parameters.
  • Ran bin/repository reparse ... --background, saw workers queue with appropriate parameters.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Include skips for SVN tests with no SVN on system.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 2 2021, 9:40 PM
This revision was automatically updated to reflect the committed changes.