Page MenuHomePhabricator

Add a "Comment content" field to Herald
ClosedPublic

Authored by epriestley on Oct 16 2020, 8:29 PM.
Tags
None
Referenced Files
F15466620: D21479.id51123.diff
Thu, Apr 3, 7:40 AM
F15444345: D21479.id.diff
Thu, Mar 27, 9:09 AM
F15442748: D21479.id51123.diff
Thu, Mar 27, 12:15 AM
F15439036: D21479.diff
Wed, Mar 26, 5:20 AM
F15430169: D21479.id.diff
Mon, Mar 24, 6:18 AM
F15410810: D21479.diff
Wed, Mar 19, 8:27 AM
F15396374: D21479.id51125.diff
Sun, Mar 16, 1:52 PM
Unknown Object (File)
Feb 22 2025, 12:24 AM
Subscribers
None

Details

Summary

Ref T13583. To improve support for making it harder to improperly mix data retention policies, allow Herald to act on comment content.

Test Plan
  • Wrote comment content Herald rules in Maniphest and Differential.
  • Submitted non-matching comments (no action) and matching comments (Herald action).
  • In Differential, triggered rules by submitting non-matching main content and a matching inline comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 16 2020, 8:43 PM
This revision was automatically updated to reflect the committed changes.