Page MenuHomePhabricator

Add a "Comment content" field to Herald
ClosedPublic

Authored by epriestley on Oct 16 2020, 8:29 PM.
Tags
None
Referenced Files
F15184022: D21479.id51123.diff
Thu, Feb 20, 11:34 AM
F15180754: D21479.id51125.diff
Wed, Feb 19, 10:10 PM
Unknown Object (File)
Fri, Feb 14, 1:58 PM
Unknown Object (File)
Sun, Feb 9, 9:54 AM
Unknown Object (File)
Sun, Feb 9, 9:54 AM
Unknown Object (File)
Sun, Feb 9, 9:54 AM
Unknown Object (File)
Sun, Feb 9, 1:12 AM
Unknown Object (File)
Mon, Feb 3, 2:18 AM
Subscribers
None

Details

Summary

Ref T13583. To improve support for making it harder to improperly mix data retention policies, allow Herald to act on comment content.

Test Plan
  • Wrote comment content Herald rules in Maniphest and Differential.
  • Submitted non-matching comments (no action) and matching comments (Herald action).
  • In Differential, triggered rules by submitting non-matching main content and a matching inline comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 16 2020, 8:43 PM
This revision was automatically updated to reflect the committed changes.