Differential D21479

Add a "Comment content" field to Herald
ClosedPublic
Actions

Authored by epriestley on Oct 16 2020, 8:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 28, 12:24 AM

	Unknown Object (File)
	Tue, Nov 26, 10:37 PM

	Unknown Object (File)
	Mon, Nov 25, 5:51 PM

	Unknown Object (File)
	Fri, Nov 22, 1:48 AM

	Unknown Object (File)
	Mon, Nov 18, 3:24 AM

	Unknown Object (File)
	Sat, Nov 16, 9:01 PM

	Unknown Object (File)
	Thu, Nov 14, 8:59 PM

	Unknown Object (File)
	Sun, Nov 10, 9:58 AM

View All 85 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13583: Support reasonable guardrails against mismatched data retention policies in comment content
Commits: rP1f7c736f9ab6: Add a "Comment content" field to Herald

Summary

Ref T13583. To improve support for making it harder to improperly mix data retention policies, allow Herald to act on comment content.

Test Plan

Wrote comment content Herald rules in Maniphest and Differential.
Submitted non-matching comments (no action) and matching comments (Herald action).
In Differential, triggered rules by submitting non-matching main content and a matching inline comment.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 16 2020, 8:29 PM

Harbormaster completed remote builds in B24938: Diff 51123.Oct 16 2020, 8:30 PM

epriestley requested review of this revision.Oct 16 2020, 8:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 16 2020, 8:43 PM

Closed by commit rP1f7c736f9ab6: Add a "Comment content" field to Herald (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP1f7c736f9ab6: Add a "Comment content" field to Herald.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

herald/

field/

HeraldCommentContentField.php

43 lines

Diff 51125

src/__phutil_library_map__.php

Loading...

src/applications/herald/field/HeraldCommentContentField.php

Loading...