Page MenuHomePhabricator

Add a "Comment content" field to Herald
ClosedPublic

Authored by epriestley on Oct 16 2020, 8:29 PM.
Tags
None
Referenced Files
F19804351: D21479.id51125.diff
Mon, Mar 2, 7:05 AM
F19071863: D21479.id51125.diff
Nov 30 2025, 8:50 PM
F18815474: D21479.id51125.diff
Oct 21 2025, 2:22 AM
F18802679: D21479.id.diff
Oct 17 2025, 7:55 PM
F18756990: D21479.id51123.diff
Oct 5 2025, 2:54 PM
F18742206: D21479.diff
Oct 2 2025, 6:03 PM
F18571332: D21479.id51125.diff
Sep 10 2025, 4:56 AM
F18571331: D21479.id51123.diff
Sep 10 2025, 4:56 AM
Subscribers
None

Details

Summary

Ref T13583. To improve support for making it harder to improperly mix data retention policies, allow Herald to act on comment content.

Test Plan
  • Wrote comment content Herald rules in Maniphest and Differential.
  • Submitted non-matching comments (no action) and matching comments (Herald action).
  • In Differential, triggered rules by submitting non-matching main content and a matching inline comment.

Diff Detail

Repository
rP Phabricator
Branch
comment1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24938
Build 34407: Run Core Tests
Build 34406: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 16 2020, 8:43 PM
This revision was automatically updated to reflect the committed changes.