Page MenuHomePhabricator

Add a "Comment content" field to Herald
ClosedPublic

Authored by epriestley on Oct 16 2020, 8:29 PM.
Tags
None
Referenced Files
F22838577: D21479.diff
Sun, Oct 11, 9:31 AM
F22703992: D21479.id51125.diff
Sat, Oct 3, 4:22 AM
F22536682: D21479.diff
Tue, Sep 22, 4:23 AM
Unknown Object (File)
Sep 16 2026, 5:00 PM
Unknown Object (File)
Aug 10 2026, 5:13 PM
Unknown Object (File)
Apr 1 2026, 7:55 AM
Unknown Object (File)
Apr 1 2026, 3:05 AM
Unknown Object (File)
Mar 13 2026, 7:34 AM
Subscribers
None

Details

Summary

Ref T13583. To improve support for making it harder to improperly mix data retention policies, allow Herald to act on comment content.

Test Plan
  • Wrote comment content Herald rules in Maniphest and Differential.
  • Submitted non-matching comments (no action) and matching comments (Herald action).
  • In Differential, triggered rules by submitting non-matching main content and a matching inline comment.

Diff Detail

Repository
rP Phabricator
Branch
comment1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24938
Build 34407: Run Core Tests
Build 34406: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 16 2020, 8:43 PM
This revision was automatically updated to reflect the committed changes.