Page MenuHomePhabricator

fail `arc diff` if second lfs push errors
ClosedPublic

Authored by ptarjan on Sep 23 2020, 8:26 PM.
Tags
None
Referenced Files
F19509126: D21471.id51109.diff
Sat, Jan 10, 3:29 PM
F19311384: D21471.id51106.diff
Wed, Dec 24, 11:11 PM
F19075049: D21471.id51109.diff
Dec 1 2025, 8:12 AM
F19073671: D21471.diff
Dec 1 2025, 2:43 AM
F18878143: D21471.diff
Nov 6 2025, 3:22 PM
F18838629: D21471.diff
Oct 27 2025, 11:51 AM
F18827005: D21471.id51109.diff
Oct 24 2025, 7:04 AM
F18783889: D21471.id51105.diff
Oct 13 2025, 10:29 AM
Subscribers

Details

Summary

We are having issues where people run out of file descriptors and the first git push will succeed, but the
second one will not. We'd like the diff to not be created in this case as it leads to weird behavior like our tests
running against 0 changed files.

Test Plan

none

Diff Detail

Repository
rARC Arcanist
Branch
fail (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24922
Build 34382: arc lint + arc unit