Page MenuHomePhabricator

fail `arc diff` if second lfs push errors
ClosedPublic

Authored by ptarjan on Sep 23 2020, 8:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 6:51 AM
Unknown Object (File)
Sat, Nov 30, 2:15 PM
Unknown Object (File)
Fri, Nov 29, 11:09 AM
Unknown Object (File)
Tue, Nov 26, 3:03 PM
Unknown Object (File)
Nov 9 2024, 1:01 AM
Unknown Object (File)
Nov 3 2024, 6:01 AM
Unknown Object (File)
Oct 20 2024, 11:27 PM
Unknown Object (File)
Oct 9 2024, 1:41 PM
Subscribers

Details

Summary

We are having issues where people run out of file descriptors and the first git push will succeed, but the
second one will not. We'd like the diff to not be created in this case as it leads to weird behavior like our tests
running against 0 changed files.

Test Plan

none

Diff Detail

Repository
rARC Arcanist
Branch
fail (branched from master)
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/workflow/ArcanistDiffWorkflow.php:2752TXT3Line Too Long
Unit
Tests Passed
Build Status
Buildable 24921
Build 34381: arc lint + arc unit