When raising a Conduit client exception, show the called method in the error message
ClosedPublic
Actions

Authored by epriestley on Sep 16 2020, 12:20 AM.

Tags

None

Referenced Files

	F15450836: D21463.id51077.diff
	Fri, Mar 28, 6:32 PM

	F15450834: D21463.id51075.diff
	Fri, Mar 28, 6:32 PM

	F15450791: D21463.diff
	Fri, Mar 28, 6:15 PM

	F15445707: D21463.id51077.diff
	Thu, Mar 27, 3:37 PM

	F15444771: D21463.id51075.diff
	Thu, Mar 27, 11:12 AM

	F15440960: D21463.id.diff
	Wed, Mar 26, 3:44 PM

	F15438039: D21463.diff
	Tue, Mar 25, 10:54 PM

	F15383761: D21463.diff
	Fri, Mar 14, 5:50 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash
Commits: rARCde209ec06488: When raising a Conduit client exception, show the called method in the error…

Summary

Ref T13581. This message can be slightly more helpful in some cases by showing which method call failed.

Test Plan

Ran arc branches under the error condition in D21462, got a more useful error.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 16 2020, 12:20 AM

Harbormaster completed remote builds in B24890: Diff 51075.Sep 16 2020, 12:20 AM

epriestley requested review of this revision.Sep 16 2020, 12:20 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:34 AM

Closed by commit rARCde209ec06488: When raising a Conduit client exception, show the called method in the error… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCde209ec06488: When raising a Conduit client exception, show the called method in the error….

epriestley mentioned this in T13625: Daemons may make commit-related API calls as users without privileges.Mar 1 2021, 6:15 PM

Revision Contents
Changeset List

Path

Size

src/

conduit/

ConduitFuture.php

7 lines

Diff 51077

View Options

src/conduit/ConduitFuture.php

When raising a Conduit client exception, show the called method in the error messageClosedPublicActions