Paths

Table of Contentst

Differential D21463

When raising a Conduit client exception, show the called method in the error message
ClosedPublic
Actions

Authored by epriestley on Sep 16 2020, 12:20 AM.

Tags

None

Referenced Files

	F19043639: D21463.id51075.diff
	Wed, Nov 26, 11:41 PM

	F18943126: D21463.diff
	Tue, Nov 11, 1:20 PM

	F18904657: D21463.id.diff
	Sat, Nov 8, 10:25 AM

	F18898255: D21463.diff
	Fri, Nov 7, 6:24 PM

	F18871573: D21463.id51077.diff
	Tue, Nov 4, 11:28 PM

	F18860340: D21463.id.diff
	Sun, Nov 2, 10:58 AM

	F18769501: D21463.id.diff
	Oct 8 2025, 7:53 AM

	F18615232: D21463.id.diff
	Sep 14 2025, 2:22 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash
Commits: rARCde209ec06488: When raising a Conduit client exception, show the called method in the error…

Summary

Ref T13581. This message can be slightly more helpful in some cases by showing which method call failed.

Test Plan

Ran arc branches under the error condition in D21462, got a more useful error.

Diff Detail

Repository

Branch

cref14

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24890
Build 34343: Run Core Tests
Build 34342: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 16 2020, 12:20 AM

Harbormaster completed remote builds in B24890: Diff 51075.Sep 16 2020, 12:20 AM

epriestley requested review of this revision.Sep 16 2020, 12:20 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:34 AM

Closed by commit rARCde209ec06488: When raising a Conduit client exception, show the called method in the error… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCde209ec06488: When raising a Conduit client exception, show the called method in the error….

epriestley mentioned this in T13625: Daemons may make commit-related API calls as users without privileges.Mar 1 2021, 6:15 PM

Revision Contents
Changeset List

Path

Size

src/

conduit/

ConduitFuture.php

7 lines

Diff 51075

src/conduit/ConduitFuture.php

Loading...