Page MenuHomePhabricator

Wrap all direct access to author/committer properties on "CommitData"
ClosedPublic

Authored by epriestley on Aug 12 2020, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 1:12 PM
Unknown Object (File)
Fri, Jan 17, 11:31 AM
Unknown Object (File)
Tue, Jan 14, 12:43 AM
Unknown Object (File)
Mon, Jan 13, 3:04 AM
Unknown Object (File)
Wed, Jan 1, 12:36 AM
Unknown Object (File)
Dec 21 2024, 2:55 AM
Unknown Object (File)
Dec 16 2024, 4:14 AM
Unknown Object (File)
Dec 9 2024, 1:35 PM
Subscribers
None

Details

Summary

Ref T13552. Currently, various callers read raw properties off "CommitData" directly. Wrap these in accessors to support storage changes which persist "CommitRef" information instead.

Test Plan
  • Ran "diffusion.querycommits", saw the same data before and after.
  • Looked at a commit, saw authorship information and date.
  • Viewed tags in a repository, saw author information.
  • Ran "rebuild-identities", saw no net effect.
  • Grepped for callers to "getCommitDetail(...)".

Diff Detail

Repository
rP Phabricator
Branch
cref7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24862
Build 34298: Run Core Tests
Build 34297: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.