Page MenuHomePhabricator
Differential D21448

Wrap all direct access to author/committer properties on "CommitData"
ClosedPublic
Actions

Authored by epriestley on Aug 12 2020, 7:42 PM.
Tags
None
Referenced Files
F14845874: D21448.id.diff
Mon, Feb 3, 1:37 AM
Unknown Object (File)
Sat, Jan 25, 8:38 AM
Unknown Object (File)
Sat, Jan 25, 8:38 AM
Unknown Object (File)
Sat, Jan 25, 8:38 AM
Unknown Object (File)
Sat, Jan 25, 8:38 AM
Unknown Object (File)
Fri, Jan 24, 8:47 AM
Unknown Object (File)
Tue, Jan 21, 1:12 PM
Unknown Object (File)
Fri, Jan 17, 11:31 AM
View All 94 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rPe454c3dafe99: Wrap all direct access to author/committer properties on "CommitData"
Summary

Ref T13552. Currently, various callers read raw properties off "CommitData" directly. Wrap these in accessors to support storage changes which persist "CommitRef" information instead.

Test Plan
  • Ran "diffusion.querycommits", saw the same data before and after.
  • Looked at a commit, saw authorship information and date.
  • Viewed tags in a repository, saw author information.
  • Ran "rebuild-identities", saw no net effect.
  • Grepped for callers to "getCommitDetail(...)".

Diff Detail

Repository
rP Phabricator
Branch
cref7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24862
Build 34298: Run Core Tests
Build 34297: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 12 2020, 7:42 PM
Harbormaster completed remote builds in B24862: Diff 51047.Aug 12 2020, 7:44 PM
epriestley requested review of this revision.Aug 12 2020, 7:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
Closed by commit rPe454c3dafe99: Wrap all direct access to author/committer properties on "CommitData" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPe454c3dafe99: Wrap all direct access to author/committer properties on "CommitData".

Revision Contents
Changeset List

Diff 51047

View Options

src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/data/DiffusionPathChange.php

Loading...
View Options

src/applications/diffusion/view/DiffusionTagListView.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommitData.php

Loading...
View Options

src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php

Loading...
Phabricator · Built by Phacility