Page MenuHomePhabricator

Wrap all direct access to author/committer properties on "CommitData"
ClosedPublic

Authored by epriestley on Aug 12 2020, 7:42 PM.

Details

Summary

Ref T13552. Currently, various callers read raw properties off "CommitData" directly. Wrap these in accessors to support storage changes which persist "CommitRef" information instead.

Test Plan
  • Ran "diffusion.querycommits", saw the same data before and after.
  • Looked at a commit, saw authorship information and date.
  • Viewed tags in a repository, saw author information.
  • Ran "rebuild-identities", saw no net effect.
  • Grepped for callers to "getCommitDetail(...)".

Diff Detail

Repository
rP Phabricator
Branch
cref7
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 24862
Build 34298: Run Core Tests
Build 34297: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.