Page MenuHomePhabricator

Wrap all direct access to author/committer properties on "CommitData"
ClosedPublic

Authored by epriestley on Aug 12 2020, 7:42 PM.
Tags
None
Referenced Files
F12840347: D21448.id.diff
Thu, Mar 28, 8:23 PM
Unknown Object (File)
Wed, Mar 27, 2:01 AM
Unknown Object (File)
Tue, Mar 19, 7:49 PM
Unknown Object (File)
Feb 22 2024, 1:47 PM
Unknown Object (File)
Feb 21 2024, 4:39 AM
Unknown Object (File)
Feb 19 2024, 7:18 AM
Unknown Object (File)
Feb 19 2024, 12:45 AM
Unknown Object (File)
Jan 19 2024, 12:10 PM
Subscribers
None

Details

Summary

Ref T13552. Currently, various callers read raw properties off "CommitData" directly. Wrap these in accessors to support storage changes which persist "CommitRef" information instead.

Test Plan
  • Ran "diffusion.querycommits", saw the same data before and after.
  • Looked at a commit, saw authorship information and date.
  • Viewed tags in a repository, saw author information.
  • Ran "rebuild-identities", saw no net effect.
  • Grepped for callers to "getCommitDetail(...)".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.